Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build system #1328

Merged
merged 9 commits into from
Mar 5, 2024
Merged

Improve build system #1328

merged 9 commits into from
Mar 5, 2024

Conversation

thomas-senechal
Copy link
Member

@thomas-senechal thomas-senechal commented Jan 22, 2024

Delivery Quality Checklist

This PR improves the build system of MS to make it more reliable and build MS the same way between the CI and on our computers during development

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

tasks/Taskfile_internal.yml Outdated Show resolved Hide resolved
@thomas-senechal thomas-senechal force-pushed the improve-build-system branch 2 times, most recently from f47c28b to 9fa2a9d Compare January 23, 2024 09:40
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22d0d44) 22.09% compared to head (951c942) 22.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1328   +/-   ##
=======================================
  Coverage   22.09%   22.09%           
=======================================
  Files          29       29           
  Lines        1715     1715           
=======================================
  Hits          379      379           
  Misses       1326     1326           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-senechal thomas-senechal marked this pull request as ready for review January 23, 2024 10:06
@Thykof Thykof force-pushed the improve-build-system branch from 17ebc30 to 951c942 Compare January 26, 2024 09:07
@Thykof Thykof merged commit 531d35e into main Mar 5, 2024
17 checks passed
@Thykof Thykof deleted the improve-build-system branch March 5, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants