-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build system #1328
Merged
Merged
Improve build system #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-senechal
force-pushed
the
improve-build-system
branch
from
January 22, 2024 22:43
ca662a5
to
d20ffd8
Compare
Thykof
reviewed
Jan 23, 2024
thomas-senechal
force-pushed
the
improve-build-system
branch
2 times, most recently
from
January 23, 2024 09:40
f47c28b
to
9fa2a9d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
=======================================
Coverage 22.09% 22.09%
=======================================
Files 29 29
Lines 1715 1715
=======================================
Hits 379 379
Misses 1326 1326
Partials 10 10 ☔ View full report in Codecov by Sentry. |
thomas-senechal
force-pushed
the
improve-build-system
branch
from
January 23, 2024 09:53
9fa2a9d
to
2a2c1ab
Compare
Thykof
approved these changes
Jan 24, 2024
Thykof
force-pushed
the
improve-build-system
branch
from
January 26, 2024 09:07
17ebc30
to
951c942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delivery Quality Checklist
This PR improves the build system of MS to make it more reliable and build MS the same way between the CI and on our computers during development
Breaking Changes in API:
Does this PR introduce breaking changes in the API?
Changelog:
Version Update Handling:
Have you ensured that the version update by user is handled correctly?
PR Dependency:
Does this PR depend on another PR?
Documentation: