Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network config in config yaml file #1320

Merged
merged 5 commits into from
Jan 11, 2024
Merged

network config in config yaml file #1320

merged 5 commits into from
Jan 11, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jan 9, 2024

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ded6c1) 22.09% compared to head (2987b46) 22.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1320   +/-   ##
=======================================
  Coverage   22.09%   22.09%           
=======================================
  Files          29       29           
  Lines        1715     1715           
=======================================
  Hits          379      379           
  Misses       1326     1326           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof linked an issue Jan 9, 2024 that may be closed by this pull request
5 tasks
@Thykof Thykof force-pushed the config-in-yaml-file branch 2 times, most recently from 5aeab4a to 5293cb8 Compare January 10, 2024 09:35
int/config/network.go Show resolved Hide resolved
int/config/network.go Outdated Show resolved Hide resolved
@Thykof Thykof force-pushed the config-in-yaml-file branch from 1819f44 to 633e972 Compare January 10, 2024 16:43
@Thykof Thykof merged commit ff19825 into main Jan 11, 2024
17 checks passed
@Thykof Thykof deleted the config-in-yaml-file branch January 11, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic network configuration file
3 participants