Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go and linter in ci #1314

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Update go and linter in ci #1314

merged 3 commits into from
Jan 8, 2024

Conversation

thomas-senechal
Copy link
Member

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b67dd38) 23.09% compared to head (1ec78d7) 17.00%.

❗ Current head 1ec78d7 differs from pull request most recent head 61becad. Consider uploading reports for the commit 61becad to get more accurate results

Files Patch % Lines
pkg/node/sendoperation/convert.go 0.00% 1 Missing ⚠️
pkg/node/sendoperation/sendoperation.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   23.09%   17.00%   -6.10%     
==========================================
  Files          30       26       -4     
  Lines        1749     1576     -173     
==========================================
- Hits          404      268     -136     
+ Misses       1332     1296      -36     
+ Partials       13       12       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-senechal thomas-senechal force-pushed the update-go-and-linter-in-ci branch from 1ec78d7 to 61becad Compare January 8, 2024 11:26
@thomas-senechal thomas-senechal marked this pull request as ready for review January 8, 2024 11:37
@Thykof Thykof merged commit 248b418 into main Jan 8, 2024
15 checks passed
@Thykof Thykof deleted the update-go-and-linter-in-ci branch January 8, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants