Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: remove unused account store #1313

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jan 5, 2024

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@Thykof Thykof linked an issue Jan 5, 2024 that may be closed by this pull request
@Thykof Thykof force-pushed the 922-remove-account-persistence-on-zustand branch from 949d006 to cb08f9e Compare January 5, 2024 17:00
@Thykof Thykof marked this pull request as draft January 5, 2024 17:00
@Thykof Thykof changed the base branch from main to clean-web-on-chain January 5, 2024 17:00
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce065ec) 22.28% compared to head (475f6c4) 22.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
- Coverage   22.28%   22.09%   -0.19%     
==========================================
  Files          28       29       +1     
  Lines        1701     1715      +14     
==========================================
  Hits          379      379              
- Misses       1312     1326      +14     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof force-pushed the clean-web-on-chain branch from 2dc82a3 to 65f7fc7 Compare January 8, 2024 12:22
@Thykof Thykof force-pushed the 922-remove-account-persistence-on-zustand branch from cb08f9e to eb54f9e Compare January 8, 2024 12:23
@Thykof Thykof force-pushed the clean-web-on-chain branch 2 times, most recently from a58e29b to c5768c4 Compare January 8, 2024 16:32
Base automatically changed from clean-web-on-chain to main January 9, 2024 09:43
@Thykof Thykof force-pushed the 922-remove-account-persistence-on-zustand branch from eb54f9e to 475f6c4 Compare January 9, 2024 09:56
@Thykof Thykof marked this pull request as ready for review January 9, 2024 09:57
@Thykof Thykof merged commit ce20d11 into main Jan 9, 2024
16 of 17 checks passed
@Thykof Thykof deleted the 922-remove-account-persistence-on-zustand branch January 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Account Persistence on Zustand
2 participants