Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean code web on chain #1312

Merged
merged 1 commit into from
Jan 9, 2024
Merged

clean code web on chain #1312

merged 1 commit into from
Jan 9, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jan 5, 2024

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10b8154) 23.08% compared to head (a58e29b) 22.09%.

❗ Current head a58e29b differs from pull request most recent head c5768c4. Consider uploading reports for the commit c5768c4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
- Coverage   23.08%   22.09%   -0.99%     
==========================================
  Files          30       29       -1     
  Lines        1750     1715      -35     
==========================================
- Hits          404      379      -25     
+ Misses       1333     1326       -7     
+ Partials       13       10       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof force-pushed the clean-web-on-chain branch 3 times, most recently from 65f7fc7 to a58e29b Compare January 8, 2024 13:24
@Thykof Thykof marked this pull request as ready for review January 8, 2024 13:26
@Thykof Thykof requested a review from thomas-senechal January 8, 2024 15:10
Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !
Just a (big) non blocking comment

int/config/network.go Show resolved Hide resolved
@Thykof Thykof force-pushed the clean-web-on-chain branch from a58e29b to c5768c4 Compare January 8, 2024 16:32
@Thykof Thykof requested a review from thomas-senechal January 8, 2024 16:32
@Thykof Thykof merged commit ce065ec into main Jan 9, 2024
15 checks passed
@Thykof Thykof deleted the clean-web-on-chain branch January 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants