Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

701 api endpoint read only executesc #1310

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jan 4, 2024

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@Thykof Thykof changed the base branch from main to 701-api-endpoint-read-only-calls January 4, 2024 09:31
@Thykof Thykof marked this pull request as draft January 4, 2024 09:31
@Thykof Thykof linked an issue Jan 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7774470) 22.09% compared to head (8101895) 22.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1310   +/-   ##
=======================================
  Coverage   22.09%   22.09%           
=======================================
  Files          29       29           
  Lines        1715     1715           
=======================================
  Hits          379      379           
  Misses       1326     1326           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof force-pushed the 701-api-endpoint-read-only-calls branch from faa215a to df9f4cf Compare January 5, 2024 09:51
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-executesc branch from dbb44fa to 68262a4 Compare January 5, 2024 10:53
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-calls branch from 534bc98 to f4cfb74 Compare January 8, 2024 12:24
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-executesc branch from 68262a4 to 4d80adc Compare January 8, 2024 12:27
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-calls branch from f4cfb74 to 04b7a59 Compare January 8, 2024 15:01
Base automatically changed from 701-api-endpoint-read-only-calls to main January 9, 2024 14:19
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-executesc branch from 4d80adc to e719923 Compare January 9, 2024 14:20
@Thykof Thykof marked this pull request as ready for review January 9, 2024 14:20
@Thykof Thykof requested a review from thomas-senechal January 9, 2024 14:21
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-executesc branch from e719923 to 8101895 Compare January 10, 2024 09:34
@Thykof Thykof merged commit 9ded6c1 into main Jan 10, 2024
17 checks passed
@Thykof Thykof deleted the 701-api-endpoint-read-only-executesc branch January 10, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement an api endpoint to allow read only calls to smart contract
2 participants