Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add read only call sc endpoint #1309

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jan 3, 2024

TODO

  • add endpoint
  • add robot framework test

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

QA

curl --location 'http://station.massa/cmd/read-only/callsc' \
--header 'Content-Type: application/json' \
--data '{
  "nickname": "fullpower",
  "name": "rien",
  "at": "AU1MPDRXuR22mwYDFCeZUDgYjcTAF1co6xujx2X6ugoHeYeGY3B5",
  "args": "",
  "coins": "1000446777777"
}'

@Thykof Thykof linked an issue Jan 3, 2024 that may be closed by this pull request
@Thykof Thykof marked this pull request as draft January 3, 2024 14:59
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-calls branch from b4016df to 10accfb Compare January 3, 2024 14:59
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (533545a) 23.08% compared to head (04b7a59) 23.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1309   +/-   ##
=======================================
  Coverage   23.08%   23.08%           
=======================================
  Files          30       30           
  Lines        1750     1750           
=======================================
  Hits          404      404           
  Misses       1333     1333           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof force-pushed the 701-api-endpoint-read-only-calls branch from 10accfb to e6f090f Compare January 3, 2024 15:01
@Thykof Thykof marked this pull request as ready for review January 4, 2024 08:27
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-calls branch from faa215a to df9f4cf Compare January 5, 2024 09:51
int/api/cmd/utils.go Outdated Show resolved Hide resolved
int/api/cmd/utils.go Outdated Show resolved Hide resolved
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-calls branch from 534bc98 to f4cfb74 Compare January 8, 2024 12:24
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-calls branch from 44383c1 to f4cfb74 Compare January 8, 2024 15:00
@Thykof Thykof force-pushed the 701-api-endpoint-read-only-calls branch from f4cfb74 to 04b7a59 Compare January 8, 2024 15:01
@Thykof Thykof merged commit b2fb810 into main Jan 9, 2024
17 checks passed
@Thykof Thykof deleted the 701-api-endpoint-read-only-calls branch January 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement an api endpoint to allow read only calls to smart contract
2 participants