Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: (macos) by pass notarize" #1307

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Revert "ci: (macos) by pass notarize" #1307

merged 1 commit into from
Jan 3, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Jan 3, 2024

This reverts commit 57d3f42.

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@Thykof Thykof self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a06393) 23.09% compared to head (1da0e04) 23.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   23.09%   23.09%           
=======================================
  Files          30       30           
  Lines        1749     1749           
=======================================
  Hits          404      404           
  Misses       1332     1332           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof marked this pull request as ready for review January 3, 2024 13:08
@Thykof Thykof merged commit 15e73fe into main Jan 3, 2024
16 of 17 checks passed
@Thykof Thykof deleted the notarise-apple branch January 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants