Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: (macos) by pass notarize #1300

Merged
merged 1 commit into from
Dec 20, 2023
Merged

ci: (macos) by pass notarize #1300

merged 1 commit into from
Dec 20, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Dec 19, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (049d105) 24.02% compared to head (57d3f42) 24.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1300   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files          28       28           
  Lines        1640     1640           
=======================================
  Hits          394      394           
  Misses       1233     1233           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof merged commit c39ddb9 into main Dec 20, 2023
17 checks passed
@Thykof Thykof deleted the bypass-notarize-temporary branch December 20, 2023 14:08
@Thykof
Copy link
Contributor Author

Thykof commented Dec 20, 2023

We need to reactivate it ASAP, before a new release ideally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants