Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nss functions: don't block on error #1299

Merged
merged 2 commits into from
Dec 21, 2023
Merged

nss functions: don't block on error #1299

merged 2 commits into from
Dec 21, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Dec 18, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@Thykof Thykof force-pushed the nss-no-blocking-error branch 2 times, most recently from fcca870 to 88822e7 Compare December 18, 2023 21:14
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8489d8c) 23.14% compared to head (5ebff9e) 23.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   23.14%   23.23%   +0.09%     
==========================================
  Files          28       28              
  Lines        1702     1704       +2     
==========================================
+ Hits          394      396       +2     
  Misses       1295     1295              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/nss/manager.go Outdated Show resolved Hide resolved
@Thykof Thykof requested a review from gregLibert December 19, 2023 13:08
@Thykof Thykof marked this pull request as ready for review December 19, 2023 15:07
@Thykof Thykof force-pushed the nss-no-blocking-error branch from 35adcd8 to c3daac4 Compare December 19, 2023 15:07
@Thykof Thykof force-pushed the nss-no-blocking-error branch from c3daac4 to 5ebff9e Compare December 20, 2023 19:11
@Thykof Thykof merged commit f6517e4 into main Dec 21, 2023
17 checks passed
@Thykof Thykof deleted the nss-no-blocking-error branch December 21, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants