-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add chain id #1297
Merged
Merged
add chain id #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
==========================================
- Coverage 23.23% 23.09% -0.15%
==========================================
Files 28 30 +2
Lines 1704 1749 +45
==========================================
+ Hits 396 404 +8
- Misses 1295 1332 +37
Partials 13 13 ☔ View full report in Codecov by Sentry. |
Thykof
force-pushed
the
add-chain-id
branch
2 times, most recently
from
December 20, 2023 18:26
24a8b07
to
2e60d46
Compare
Thykof
commented
Dec 20, 2023
thomas-senechal
approved these changes
Dec 27, 2023
CI seems to fail |
CI fails because buildnet is not handling chain id yet |
peterjah
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to massalabs/massa#4583
Delivery Quality Checklist
Breaking Changes in API:
Does this PR introduce breaking changes in the API?
Changelog:
Version Update Handling:
Have you ensured that the version update by user is handled correctly?
PR Dependency:
Does this PR depend on another PR?
Documentation: