Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chain id #1297

Merged
merged 6 commits into from
Jan 2, 2024
Merged

add chain id #1297

merged 6 commits into from
Jan 2, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Dec 18, 2023

related to massalabs/massa#4583

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f6517e4) 23.23% compared to head (5082416) 23.09%.

Files Patch % Lines
pkg/node/sendoperation/sendoperation.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
- Coverage   23.23%   23.09%   -0.15%     
==========================================
  Files          28       30       +2     
  Lines        1704     1749      +45     
==========================================
+ Hits          396      404       +8     
- Misses       1295     1332      +37     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof self-assigned this Dec 18, 2023
@Thykof Thykof marked this pull request as draft December 19, 2023 15:06
@Thykof Thykof force-pushed the add-chain-id branch 2 times, most recently from 24a8b07 to 2e60d46 Compare December 20, 2023 18:26
@Thykof Thykof requested a review from peterjah December 20, 2023 18:27
int/config/network.go Show resolved Hide resolved
@damip damip marked this pull request as ready for review January 2, 2024 11:23
@damip
Copy link
Member

damip commented Jan 2, 2024

CI seems to fail

@Thykof
Copy link
Contributor Author

Thykof commented Jan 2, 2024

CI seems to fail

CI fails because buildnet is not handling chain id yet

@damip damip merged commit 71b4545 into main Jan 2, 2024
14 of 17 checks passed
@damip damip deleted the add-chain-id branch January 2, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants