Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1286 remove acrylic dns from windows installer #1293

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

thomas-senechal
Copy link
Member

@thomas-senechal thomas-senechal commented Dec 11, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

QA Review

  1. Uninstall MS
  2. Download the installer from https://github.com/massalabs/station/actions/runs/7169232980?pr=1293
  3. Install MS
  4. Run MS, it should work fine (except WoC since *.massa is disable)
  5. Open file explorer and copy paste the following path:
    %windir%\System32\drivers\etc\
    
  6. Open the hosts file
  7. You should see a line with 127.0.0.1 station.massa
  8. You can close the file, but not the file explorer
  9. Uninstall MS again
  10. Reopen the hosts file
  11. You should see no line mentionning station.massa

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c68a324) 25.46% compared to head (c5cf790) 25.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1293   +/-   ##
=======================================
  Coverage   25.46%   25.46%           
=======================================
  Files          25       25           
  Lines        1547     1547           
=======================================
  Hits          394      394           
  Misses       1140     1140           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gregLibert gregLibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A side note:

We might consider renaming our installer files, using 'installer' as a prefix. This would ensure they appear first in the list of artifacts and enhance readability.

What do you think? Of course, this change should be addressed in a separate issue and would require synchronization with the website, among other things.

@thomas-senechal
Copy link
Member Author

A side note:

We might consider renaming our installer files, using 'installer' as a prefix. This would ensure they appear first in the list of artifacts and enhance readability.

What do you think? Of course, this change should be addressed in a separate issue and would require synchronization with the website, among other things.

If you are talking about the release artifacts, I'm not sure it's really important since most people are using the website to download the installers.

But this change shouldn't take much time and should be better for users downloading throught GitHub releases

@thomas-senechal thomas-senechal marked this pull request as ready for review December 12, 2023 08:47
@thomas-senechal thomas-senechal merged commit d9e2f96 into main Dec 12, 2023
17 checks passed
@thomas-senechal thomas-senechal deleted the 1286-remove-acrylic-dns-from-windows-installer branch December 12, 2023 09:31
@thomas-senechal thomas-senechal linked an issue Dec 12, 2023 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace local DNS with hosts file in installation process
3 participants