Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1286 replace dns with hosts file macos #1292

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

thomas-senechal
Copy link
Member

@thomas-senechal thomas-senechal commented Dec 8, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

QA Review

  1. Uninstall MS
  2. Download the installer from https://github.com/massalabs/station/actions/runs/7143188946
  3. Install MS
  4. Run MS, it should work fine (except WoC since *.massa is disable)
  5. Open a terminal and copy paste:
    grep "station.massa" /etc/hosts
    
  6. You should see a line with 127.0.0.1 station.massa
  7. Uninstall MS again
  8. Open a terminal and copy paste:
    grep "station.massa" /etc/hosts
    
  9. You should see no new line

@thomas-senechal thomas-senechal force-pushed the 1286-replace-dns-with-hosts-file-macos branch from d802257 to 9c2fdb9 Compare December 8, 2023 16:08
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9e2f96) 25.46% compared to head (741017e) 25.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1292   +/-   ##
=======================================
  Coverage   25.46%   25.46%           
=======================================
  Files          25       25           
  Lines        1547     1547           
=======================================
  Hits          394      394           
  Misses       1140     1140           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-senechal thomas-senechal marked this pull request as ready for review December 8, 2023 16:10
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on mac amd64

installer/macos/scripts/postinstall Show resolved Hide resolved
installer/macos/scripts/postinstall Outdated Show resolved Hide resolved
@thomas-senechal thomas-senechal force-pushed the 1286-replace-dns-with-hosts-file-macos branch from dd9e22a to 741017e Compare December 12, 2023 09:32
@thomas-senechal thomas-senechal linked an issue Dec 12, 2023 that may be closed by this pull request
6 tasks
@thomas-senechal
Copy link
Member Author

Tested by Nathan, Solène and myself on ARM64 and AMD64

@thomas-senechal thomas-senechal merged commit ffbe603 into main Dec 12, 2023
17 checks passed
@thomas-senechal thomas-senechal deleted the 1286-replace-dns-with-hosts-file-macos branch December 12, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace local DNS with hosts file in installation process
3 participants