Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webonchain will come back #1291

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Dec 8, 2023

image

@Thykof Thykof linked an issue Dec 8, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffbe603) 25.46% compared to head (0ac3ade) 25.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1291   +/-   ##
=======================================
  Coverage   25.46%   25.46%           
=======================================
  Files          25       25           
  Lines        1547     1547           
=======================================
  Hits          394      394           
  Misses       1140     1140           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof force-pushed the 1290-ui-web-on-chain-coming-soon branch from adabb91 to 95ffb2f Compare December 8, 2023 15:22
@thomas-senechal thomas-senechal force-pushed the 1290-ui-web-on-chain-coming-soon branch from 95ffb2f to 76835b5 Compare December 12, 2023 08:48
Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Waiting for @SlnPons approval to merge

@thomas-senechal thomas-senechal force-pushed the 1290-ui-web-on-chain-coming-soon branch from 76835b5 to 7a8f5b6 Compare December 12, 2023 09:32
web/massastation/src/i18n/en_US.json Outdated Show resolved Hide resolved
web/massastation/src/i18n/en_US.json Outdated Show resolved Hide resolved
@thomas-senechal
Copy link
Member

We had a talk with @SlnPons about the placeholder sentances and decided to go with:

A new way to use web is coming
We are crafting a new era for our web on-chain feature…

@thomas-senechal
Copy link
Member

image

@thomas-senechal thomas-senechal force-pushed the 1290-ui-web-on-chain-coming-soon branch from 7a8f5b6 to 08dcc67 Compare December 12, 2023 12:26
@thomas-senechal thomas-senechal merged commit 3669bfe into main Dec 12, 2023
17 checks passed
@thomas-senechal thomas-senechal deleted the 1290-ui-web-on-chain-coming-soon branch December 12, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI for web on chain removal
5 participants