Sign and notarize macos app and installer

[Thykof]

Delivery Quality Checklist

• Breaking Changes in API:
  Does this PR introduce breaking changes in the API?

  • If yes, have you considered making it backward compatible?
  • If backward compatibility is not considered, set the "breaking-change" label.

• Changelog:

  • For bugfix PR, set the "bugfix" label
  • If this change should not appear in changelog, use "ignore-for-changelog" label

• Version Update Handling:
  Have you ensured that the version update by user is handled correctly?

• PR Dependency:
  Does this PR depend on another PR?

  • If yes, is it necessary for the dependency to be released prior to merging this one?

• Documentation:

  • Are any necessary changes made to user-facing documentation?
  • Confirm that API documentation is updated with any relevant changes.
  • Check that README and other documentation files are accurate and current.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ed54ff) 25.46% compared to head (cbbafa3) 25.46%.

❗ Current head cbbafa3 differs from pull request most recent head d0dca83. Consider uploading reports for the commit d0dca83 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1281   +/-   ##
=======================================
  Coverage   25.46%   25.46%           
=======================================
  Files          25       25           
  Lines        1547     1547           
=======================================
  Hits          394      394           
  Misses       1140     1140           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thomas-senechal]

Did you tried to run the create_pkg.sh script from your computer without the Dev IDs ?
What happens in that case ?

If packaging fails or if the installer does not work, I think we need to add an handling of building with and without the Dev IDs. Otherwise, we won't be able to build from our computers and will require to push, wait for 15min, to then check if it's working. And it's not a viable way of working IMO

[Thykof]

Did you tried to run the create_pkg.sh script from your computer without the Dev IDs ? What happens in that case ?

If packaging fails or if the installer does not work, I think we need to add an handling of building with and without the Dev IDs. Otherwise, we won't be able to build from our computers and will require to push, wait for 15min, to then check if it's working. And it's not a viable way of working IMO

I modifier the script, you can now run ./macos/create_pkg.sh amd64 "Developer ID Application: Massa Labs (9X8NWA3JHQ)" "Developer ID Installer: Massa Labs (9X8NWA3JHQ)" or ./macos/create_pkg.sh amd64

[thomas-senechal]

Good job !
Only a non blocking comment

[Thykof]

QA on amr64 and amd64 OK