-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1269 read only execute sc #1273
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
+ Coverage 17.59% 23.14% +5.55%
==========================================
Files 24 28 +4
Lines 1466 1702 +236
==========================================
+ Hits 258 394 +136
- Misses 1196 1295 +99
- Partials 12 13 +1 ☔ View full report in Codecov by Sentry. |
eff8a9d
to
fcd7753
Compare
b77cbf2
to
aaa52e7
Compare
aaa52e7
to
f94c099
Compare
c8132af
to
9fda1b3
Compare
56aad21
to
a8b77c7
Compare
a8b77c7
to
5d28478
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the swagger file:
maxGas:
$ref: "#/definitions/Amount"
description: Maximum number of gas unit that a operation will be able consume.
default: 700000000 # DefaultGasLimit
Amount:
description: Amount in nanoMassa.
type: string
x-nullable: false
I think there is better to do here.
I suggest to allow amount to be nullable here, and if null, do the estimation.
If we don't want to change the behaviour everywhere, you can create a new swagger type 'nullableAmount' by instance...
update readonly to v27 add 10% to gas cost estimation clean code, return an error fix 'EstimateGasCost' in robot tests
26f38f6
to
8f948c7
Compare
Delivery Quality Checklist
Breaking Changes in API:
Does this PR introduce breaking changes in the API?
Changelog:
Version Update Handling:
Have you ensured that the version update by user is handled correctly?
PR Dependency:
Does this PR depend on another PR?
Documentation: