Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1269 read only execute sc #1273

Merged
merged 4 commits into from
Dec 20, 2023
Merged

1269 read only execute sc #1273

merged 4 commits into from
Dec 20, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Nov 16, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (c39ddb9) 17.59% compared to head (8f948c7) 23.14%.

Files Patch % Lines
pkg/node/sendoperation/readonlycall.go 0.00% 64 Missing ⚠️
pkg/node/sendoperation/interfaces.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
+ Coverage   17.59%   23.14%   +5.55%     
==========================================
  Files          24       28       +4     
  Lines        1466     1702     +236     
==========================================
+ Hits          258      394     +136     
- Misses       1196     1295      +99     
- Partials       12       13       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof linked an issue Nov 16, 2023 that may be closed by this pull request
@Thykof Thykof force-pushed the 1269-read-only-execute-sc branch 4 times, most recently from eff8a9d to fcd7753 Compare November 21, 2023 14:46
@Thykof Thykof changed the base branch from main to 1269-read-only-call-sc November 21, 2023 17:43
@Thykof Thykof force-pushed the 1269-read-only-execute-sc branch 2 times, most recently from b77cbf2 to aaa52e7 Compare November 21, 2023 18:08
@Thykof Thykof force-pushed the 1269-read-only-execute-sc branch from aaa52e7 to f94c099 Compare December 6, 2023 18:57
@Thykof Thykof force-pushed the 1269-read-only-call-sc branch from c8132af to 9fda1b3 Compare December 18, 2023 21:20
@Thykof Thykof force-pushed the 1269-read-only-execute-sc branch 3 times, most recently from 56aad21 to a8b77c7 Compare December 19, 2023 04:13
Base automatically changed from 1269-read-only-call-sc to main December 19, 2023 04:39
@Thykof Thykof force-pushed the 1269-read-only-execute-sc branch from a8b77c7 to 5d28478 Compare December 19, 2023 04:43
@Thykof Thykof marked this pull request as ready for review December 19, 2023 04:43
pkg/onchain/sc.go Outdated Show resolved Hide resolved
pkg/onchain/sc.go Outdated Show resolved Hide resolved
Copy link
Contributor

@peterjah peterjah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the swagger file:

              maxGas:
                $ref: "#/definitions/Amount"
                description: Maximum number of gas unit that a operation will be able consume.
                default: 700000000 # DefaultGasLimit
  Amount:
    description: Amount in nanoMassa.
    type: string
    x-nullable: false

I think there is better to do here.
I suggest to allow amount to be nullable here, and if null, do the estimation.
If we don't want to change the behaviour everywhere, you can create a new swagger type 'nullableAmount' by instance...

@Thykof Thykof requested a review from peterjah December 20, 2023 13:38
update readonly to v27

add 10% to gas cost estimation

clean code, return an error

fix 'EstimateGasCost' in robot tests
@Thykof Thykof force-pushed the 1269-read-only-execute-sc branch from 26f38f6 to 8f948c7 Compare December 20, 2023 14:09
@Thykof Thykof merged commit 8489d8c into main Dec 20, 2023
16 of 17 checks passed
@Thykof Thykof deleted the 1269-read-only-execute-sc branch December 20, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function to callibrate max_gas parameter for web-on-chain
3 participants