Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add estimate gas with read only call for call SC #1271

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Nov 16, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@Thykof Thykof linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (b0ae132) 25.46% compared to head (c1eedbf) 24.02%.

Files Patch % Lines
pkg/node/sendoperation/readonlycall.go 0.00% 65 Missing ⚠️
pkg/node/sendoperation/interfaces.go 0.00% 22 Missing ⚠️
pkg/node/sendoperation/convert.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   25.46%   24.02%   -1.45%     
==========================================
  Files          25       28       +3     
  Lines        1547     1640      +93     
==========================================
  Hits          394      394              
- Misses       1140     1233      +93     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof force-pushed the 1269-read-only-call-sc branch from d7ea535 to 22c7c38 Compare November 16, 2023 22:14
@Thykof Thykof force-pushed the 1269-read-only-call-sc branch 2 times, most recently from 136b372 to 02ea30c Compare November 21, 2023 14:46
@Thykof Thykof force-pushed the 1269-read-only-call-sc branch from c8132af to 9fda1b3 Compare December 18, 2023 21:20
@Thykof Thykof merged commit 049d105 into main Dec 19, 2023
15 of 17 checks passed
@Thykof Thykof deleted the 1269-read-only-call-sc branch December 19, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function to callibrate max_gas parameter for web-on-chain
2 participants