Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename struct Wallet into Account #1270

Merged
merged 3 commits into from
Nov 17, 2023
Merged

rename struct Wallet into Account #1270

merged 3 commits into from
Nov 17, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Nov 16, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1b8cfd) 25.19% compared to head (0c7b747) 25.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1270   +/-   ##
=======================================
  Coverage   25.19%   25.19%           
=======================================
  Files          25       25           
  Lines        1564     1564           
=======================================
  Hits          394      394           
  Misses       1157     1157           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, otherwise it's good to me

pkg/my/domain.go Outdated Show resolved Hide resolved
Co-authored-by: Thomas Sénéchal <[email protected]>
@Thykof Thykof merged commit 8234af1 into main Nov 17, 2023
10 checks passed
@Thykof Thykof deleted the rename-some-variables branch November 17, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants