Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tos to macos installer #1241

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Add tos to macos installer #1241

merged 4 commits into from
Oct 23, 2023

Conversation

thomas-senechal
Copy link
Member

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50e16e6) 25.27% compared to head (2c354ab) 25.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   25.27%   25.27%           
=======================================
  Files          25       25           
  Lines        1559     1559           
=======================================
  Hits          394      394           
  Misses       1152     1152           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-senechal thomas-senechal force-pushed the add-tos-to-macos-installer branch from f55d077 to 9321be6 Compare October 19, 2023 14:12
@thomas-senechal thomas-senechal marked this pull request as ready for review October 19, 2023 14:28
@thomas-senechal
Copy link
Member Author

@Thykof Thykof merged commit d7468e5 into main Oct 23, 2023
17 checks passed
@Thykof Thykof deleted the add-tos-to-macos-installer branch October 23, 2023 14:41
@thomas-senechal thomas-senechal linked an issue Oct 25, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User must agree on T&C before install
2 participants