Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite Manually install the HTTPS certificate #1240

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Oct 19, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ab9b61) 25.27% compared to head (0709a8b) 27.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
+ Coverage   25.27%   27.70%   +2.43%     
==========================================
  Files          25       23       -2     
  Lines        1559     1422     -137     
==========================================
  Hits          394      394              
+ Misses       1152     1015     -137     
  Partials       13       13              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof added the documentation Improvements or additions to documentation label Oct 23, 2023
INSTALLATION.md Outdated Show resolved Hide resolved
INSTALLATION.md Outdated Show resolved Hide resolved
@Thykof Thykof force-pushed the improve-doc-certificate branch from 6e0ce2a to ead2402 Compare October 26, 2023 14:31
@Thykof Thykof force-pushed the improve-doc-certificate branch from ead2402 to 0709a8b Compare November 2, 2023 14:47
@Thykof Thykof merged commit 7c20ff2 into main Nov 6, 2023
17 checks passed
@Thykof Thykof deleted the improve-doc-certificate branch November 6, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants