Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error formating with nil pointers #1235

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Oct 18, 2023

Encountered this while working on massalabs/station-massa-wallet#778

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

@Thykof Thykof added the bugfix bugfix PR label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4e18860) 25.66% compared to head (9e8cdff) 25.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   25.66%   25.66%           
=======================================
  Files          25       25           
  Lines        1535     1535           
=======================================
  Hits          394      394           
  Misses       1128     1128           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof force-pushed the bugfix-listen-event-nil-pointer branch from 1de1a2d to 5c12143 Compare October 18, 2023 13:00
pkg/node/events.go Outdated Show resolved Hide resolved
api/test/robot_tests/cmd/keywords.resource Outdated Show resolved Hide resolved
@Thykof Thykof marked this pull request as draft October 18, 2023 14:23
@Thykof Thykof force-pushed the bugfix-listen-event-nil-pointer branch from 5c12143 to d5420bd Compare October 18, 2023 14:30
@Thykof Thykof marked this pull request as ready for review October 19, 2023 12:06
pkg/node/events.go Outdated Show resolved Hide resolved
@Thykof Thykof merged commit 6209444 into main Oct 19, 2023
10 checks passed
@Thykof Thykof deleted the bugfix-listen-event-nil-pointer branch October 19, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix bugfix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants