Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network storage cost #1234

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Network storage cost #1234

merged 2 commits into from
Oct 19, 2023

Conversation

peterjah
Copy link
Contributor

No description provided.

@peterjah peterjah force-pushed the network_storage_cost branch from 49a20e4 to 5d39bd5 Compare October 18, 2023 09:41
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (4e18860) 25.66% compared to head (b3856f2) 27.96%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
+ Coverage   25.66%   27.96%   +2.29%     
==========================================
  Files          25       21       -4     
  Lines        1535     1402     -133     
==========================================
- Hits          394      392       -2     
+ Misses       1128      997     -131     
  Partials       13       13              
Files Coverage Δ
pkg/node/sendoperation/sendoperation.go 20.91% <0.00%> (-3.90%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterjah peterjah force-pushed the network_storage_cost branch from 5d39bd5 to 11e73b7 Compare October 18, 2023 09:43
Copy link
Contributor

@gregLibert gregLibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark. How should I test it ?

int/config/network.go Outdated Show resolved Hide resolved
@peterjah peterjah force-pushed the network_storage_cost branch from 11e73b7 to e665edf Compare October 19, 2023 08:12
@peterjah
Copy link
Contributor Author

One small remark. How should I test it ?

For now this only impact webOnchain, so you can try to deploy a website on testnet.
But i already spend time to adapt the robot tests so everything pass on tesnet26. (it is testing bunch of stuff like deploy sc and WoC).

@peterjah peterjah force-pushed the network_storage_cost branch 3 times, most recently from 50a28e7 to c24a865 Compare October 19, 2023 12:07
@peterjah peterjah force-pushed the network_storage_cost branch from c24a865 to b3856f2 Compare October 19, 2023 13:34
@peterjah peterjah merged commit 50e16e6 into main Oct 19, 2023
16 of 17 checks passed
@peterjah peterjah deleted the network_storage_cost branch October 19, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants