Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust version to 1.81 #4750

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Update rust version to 1.81 #4750

merged 5 commits into from
Sep 30, 2024

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Sep 30, 2024

No description provided.

Leo-Besancon
Leo-Besancon reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this chore PR!
Will you also cherry-pick on main? I thought you needed this for the CI on non-breaking updates based on the main branch.

massa-bootstrap/src/server.rs Outdated Show resolved Hide resolved
massa-client/src/settings.rs Show resolved Hide resolved
@sydhds
Copy link
Contributor Author

sydhds commented Sep 30, 2024

Thanks for this chore PR! Will you also cherry-pick on main? I thought you needed this for the CI on non-breaking updates based on the main branch.

Doing this in main breaks many unit test so best to stay here for now I would say...

@Leo-Besancon
Copy link
Collaborator

Thanks for this chore PR! Will you also cherry-pick on main? I thought you needed this for the CI on non-breaking updates based on the main branch.

Doing this in main breaks many unit test so best to stay here for now I would say...

Interesting, do you know what causes this different behaviour between main and mainnet_2_3?
Because that means everything we release on main will have a broken CI as I understand it, it may be acceptable if we release soonish, but we have to keep this in mind :).

Approving as is then!

@sydhds sydhds merged commit 149a6e1 into mainnet_2_3 Sep 30, 2024
9 of 10 checks passed
Leo-Besancon pushed a commit that referenced this pull request Nov 21, 2024
@sydhds @Leo-Besancon
Update rust version to 1.81 (#4750)
38b63c3 
* Update rust version to 1.81

* Cargo clippy & fmt pass

* Cargo clippy & fmt pass 2

* Cargo clippy & fmt pass 3

* Remove commented code
github-merge-queue bot pushed a commit that referenced this pull request Nov 22, 2024
@Leo-Besancon @sydhds @bilboquet
Update MAIN.2.4 (#4774)
1965bec 
* Update massa-sc-runtime to include fix of as_abort

* Update Version and package to MAIN.2.4

* Update rust version to 1.81 (#4750)

* Update rust version to 1.81

* Cargo clippy & fmt pass

* Cargo clippy & fmt pass 2

* Cargo clippy & fmt pass 3

* Remove commented code

* Fix outdated UT

Signed-off-by: Jean-François <[email protected]>

* Fix new clippy warnings

---------

Signed-off-by: Jean-François <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: Jean-François <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@bilboquet bilboquet Awaiting requested review from bilboquet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydhds @Leo-Besancon