Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ASC trigger comment #4740

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Update ASC trigger comment #4740

merged 3 commits into from
Aug 12, 2024

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon requested a review from damip August 12, 2024 09:29
damip
damip previously approved these changes Aug 12, 2024
@damip damip added this pull request to the merge queue Aug 12, 2024
@damip damip removed this pull request from the merge queue due to a manual request Aug 12, 2024
@Leo-Besancon Leo-Besancon added this pull request to the merge queue Aug 12, 2024
@Leo-Besancon Leo-Besancon removed this pull request from the merge queue due to a manual request Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (77898f2) to head (57dd06a).

Files Patch % Lines
massa-ledger-exports/src/ledger_changes.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4740   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo-Besancon Leo-Besancon added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 07b093c Aug 12, 2024
13 checks passed
sydhds pushed a commit that referenced this pull request Oct 2, 2024
* Update ASC trigger comment

* Add comment for ledger entry deletions

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants