Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase execution stack size #4726

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Increase execution stack size #4726

merged 7 commits into from
Jul 17, 2024

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon enabled auto-merge July 15, 2024 08:32
@Leo-Besancon Leo-Besancon requested review from sydhds and damip July 15, 2024 08:32
@Leo-Besancon Leo-Besancon requested a review from modship July 16, 2024 05:26
Copy link
Contributor

@sydhds sydhds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good but I would have recommended to do the modification (stack size increase) then push another PR for the version updates

massa-execution-worker/src/worker.rs Outdated Show resolved Hide resolved
@Leo-Besancon
Copy link
Collaborator Author

All good but I would have recommended to do the modification (stack size increase) then push another PR for the version updates

That's true, it would probably be better like that

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.78%. Comparing base (7620cbb) to head (5d3f877).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4726   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo-Besancon
Copy link
Collaborator Author

All good but I would have recommended to do the modification (stack size increase) then push another PR for the version updates

The version update is done in #4730 instead of this one.

@Leo-Besancon Leo-Besancon requested a review from sydhds July 17, 2024 06:47
@Leo-Besancon Leo-Besancon added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit daeb398 Jul 17, 2024
12 checks passed
Leo-Besancon added a commit that referenced this pull request Jul 17, 2024
* Increase execution stack size

* fmt

* Update version to MAIN.2.3 (#4727)

* review comment

* Revert "Update version to MAIN.2.3 (#4727)"

This reverts commit 3f07ced.

* Update worker.rs

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants