New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openrpc get_status : minimal_fees #4712

Merged

modship merged 1 commit into main from rpcspec_minimal_fees

Jun 18, 2024

Member

modship commented Jun 18, 2024

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification


          minimal_fees in get_status

3d7e9bf

modship requested a review from Leo-Besancon

June 18, 2024 09:19

Leo-Besancon approved these changes

View reviewed changes

modship enabled auto-merge

June 18, 2024 09:28

modship added this pull request to the merge queue

Merged via the queue into main with commit 721f4ce

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet