Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GRPC querystate endpoint #4707

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Fix GRPC querystate endpoint #4707

merged 3 commits into from
Jun 13, 2024

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon requested a review from damip June 13, 2024 16:27
damip
damip previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@Leo-Besancon Leo-Besancon changed the title Update mapping_grpc.rs Fix GRPC querystate endpoint Jun 13, 2024
@Leo-Besancon Leo-Besancon enabled auto-merge June 13, 2024 16:45
@Leo-Besancon Leo-Besancon added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 37e9307 Jun 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leo-Besancon @damip