Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests all features #4705

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Fix tests all features #4705

merged 7 commits into from
Jun 12, 2024

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Jun 12, 2024

The goal of this PR is to enable --all-feature on our CI tests configuration.

As a result, all tests will be triggered, and a few fix where needed:

  • sandbox is active so chain_id is 77 and the default final_state changes (new SC addresses in tests)
  • execution-trace is active and the TU didn't pass
  • dump-block is active, along with both backend types, so a few fixes where needed
  • heavy testing is disabled is the env var "NEXTEST" is set and at "1"
  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.78%. Comparing base (a804a2c) to head (29e1250).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4705   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bilboquet bilboquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.
It's ok for me.

@Leo-Besancon Leo-Besancon added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 0490df8 Jun 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants