Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded pub #4704

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Remove unneeded pub #4704

merged 1 commit into from
Jun 13, 2024

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon requested a review from sydhds June 12, 2024 05:58
@Leo-Besancon Leo-Besancon mentioned this pull request Jun 12, 2024
Closed
@Leo-Besancon Leo-Besancon enabled auto-merge June 12, 2024 05:59
@Leo-Besancon Leo-Besancon requested a review from bilboquet June 13, 2024 13:34
@Leo-Besancon Leo-Besancon added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit cc3c52c Jun 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilboquet bilboquet bilboquet approved these changes

@sydhds sydhds Awaiting requested review from sydhds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leo-Besancon @bilboquet