New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add file and db backend for dump-block feature #4693

Merged

bilboquet merged 1 commit into main from dump_block_backend

May 16, 2024

Contributor

bilboquet commented May 15, 2024

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

bilboquet requested a review from AurelienFT

May 15, 2024 15:27

bilboquet force-pushed the dump_block_backend branch from d293f13 to b707276 Compare

May 16, 2024 07:41


          add file and db backend for dump-block feature

71aa5fe

Signed-off-by: Jean-François <[email protected]>

bilboquet force-pushed the dump_block_backend branch from 2cf8d6e to 71aa5fe Compare

May 16, 2024 10:04

AurelienFT approved these changes

View reviewed changes

Contributor

AurelienFT left a comment

LGTM

bilboquet added this pull request to the merge queue

Merged via the queue into main with commit a949f65

11 checks passed

bilboquet deleted the dump_block_backend branch

May 28, 2024 09:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet