Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few old links in README #4686

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix a few old links in README #4686

merged 1 commit into from
May 20, 2024

Conversation

m4ns0ur
Copy link
Contributor

@m4ns0ur m4ns0ur commented May 6, 2024 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

AurelienFT
AurelienFT approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thank you for the contribution. We currently have an issue on the CI that will be fixed by the upcoming pull request and we will merge your contribution as soon as it's fixed.

@AurelienFT AurelienFT enabled auto-merge May 13, 2024 14:21
auto-merge was automatically disabled May 15, 2024 19:16

Head branch was pushed to by a user without write access

@m4ns0ur m4ns0ur force-pushed the fix-old-links-readme branch from c4c6e98 to 2fc4328 Compare May 15, 2024 19:16
@AurelienFT AurelienFT enabled auto-merge May 16, 2024 12:34
@AurelienFT AurelienFT mentioned this pull request May 16, 2024
Closed
@AurelienFT AurelienFT added this pull request to the merge queue May 20, 2024
Merged via the queue into massalabs:main with commit af84432 May 20, 2024
9 of 10 checks passed
@m4ns0ur m4ns0ur deleted the fix-old-links-readme branch May 23, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m4ns0ur @AurelienFT