Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial code for dump-block feature #4684

Merged
merged 11 commits into from
May 13, 2024
Merged

Initial code for dump-block feature #4684

merged 11 commits into from
May 13, 2024

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Apr 25, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested a review from AurelienFT April 29, 2024 12:04
@sydhds sydhds marked this pull request as ready for review April 29, 2024 12:04
AurelienFT
AurelienFT reviewed Apr 29, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
massa-execution-worker/src/execution.rs Show resolved Hide resolved
@sydhds sydhds requested a review from AurelienFT April 29, 2024 13:40
@AurelienFT AurelienFT added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit a1a2190 May 13, 2024
11 checks passed
@sydhds sydhds mentioned this pull request May 13, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydhds @AurelienFT