Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!Version MAIN.2.2 #4676

Merged
merged 3 commits into from
May 30, 2024
Merged

!Version MAIN.2.2 #4676

merged 3 commits into from
May 30, 2024

Conversation

modship
Copy link
Member

@modship modship commented Apr 11, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship requested a review from AurelienFT April 11, 2024 07:25
@modship modship marked this pull request as draft April 11, 2024 07:58
@Leo-Besancon Leo-Besancon marked this pull request as ready for review May 30, 2024 07:27
@Leo-Besancon Leo-Besancon added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 5bc7fb0 May 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@AurelienFT AurelienFT Awaiting requested review from AurelienFT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modship @Leo-Besancon