Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check minimal fees on read only without fees #4675

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Do not check minimal fees on read only without fees #4675

merged 2 commits into from
Apr 10, 2024

Conversation

AurelienFT
Copy link
Contributor

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@AurelienFT AurelienFT requested a review from modship April 10, 2024 11:57
@AurelienFT AurelienFT enabled auto-merge April 10, 2024 11:58
@AurelienFT AurelienFT mentioned this pull request Apr 10, 2024
Merged
@AurelienFT AurelienFT added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 07b8c52 Apr 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thykof Thykof Thykof approved these changes

@modship modship modship approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienFT @modship @Thykof