Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal fees #4664

Merged
merged 15 commits into from
Apr 4, 2024
Merged

minimal fees #4664

merged 15 commits into from
Apr 4, 2024

Conversation

modship
Copy link
Member

@modship modship commented Mar 26, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Ownership: Massa Foundation

@modship modship added enhancement New feature or request api Issues related to the API production Issues related to block/operation production labels Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 62.16216% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 71.78%. Comparing base (df156f3) to head (87c07e3).
Report is 2 commits behind head on main.

Files Patch % Lines
massa-client/src/cmds.rs 0.00% 15 Missing ⚠️
massa-api/src/public.rs 87.87% 4 Missing ⚠️
massa-grpc/src/stream/send_operations.rs 40.00% 3 Missing ⚠️
massa-node/src/main.rs 0.00% 3 Missing ⚠️
massa-api-exports/src/node.rs 0.00% 1 Missing ⚠️
massa-grpc/src/config.rs 0.00% 1 Missing ⚠️
massa-grpc/src/public.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4664   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@modship modship marked this pull request as ready for review April 2, 2024 07:46
@modship modship requested a review from AurelienFT April 2, 2024 07:50
Cargo.toml Outdated Show resolved Hide resolved
massa-pool-exports/src/config.rs Outdated Show resolved Hide resolved
massa-api/src/public.rs Outdated Show resolved Hide resolved
massa-api/src/public.rs Outdated Show resolved Hide resolved
massa-api/src/public.rs Outdated Show resolved Hide resolved
massa-node/base_config/config.toml Outdated Show resolved Hide resolved
massa-pool-worker/src/operation_pool.rs Outdated Show resolved Hide resolved
@modship modship added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 8b23f0a Apr 4, 2024
12 checks passed
@damip damip added the Massa Foundation Mandated by the Massa Foundation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API enhancement New feature or request Massa Foundation Mandated by the Massa Foundation production Issues related to block/operation production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants