Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add effective received amount field #4660

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

AurelienFT
Copy link
Contributor

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Not ideal because it doesn't work with transfers made in ABI

@AurelienFT AurelienFT requested a review from Leo-Besancon March 11, 2024 07:38
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AurelienFT AurelienFT enabled auto-merge March 11, 2024 07:57
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 71.78%. Comparing base (7dd1ac2) to head (d6f8541).

Files Patch % Lines
massa-execution-worker/src/execution.rs 34.78% 15 Missing ⚠️
massa-api/src/public.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4660   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienFT AurelienFT added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit df156f3 Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants