Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gathering of transfers in the node + prep work for ABIs #4646

Merged
merged 29 commits into from
Feb 22, 2024

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Feb 15, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (f88b1c6) 71.78% compared to head (c1c7ffd) 71.78%.

Files Patch % Lines
massa-grpc/src/handler.rs 59.49% 32 Missing ⚠️
massa-execution-worker/src/execution.rs 82.27% 28 Missing ⚠️
massa-grpc/src/public.rs 87.24% 25 Missing ⚠️
massa-node/src/main.rs 0.00% 13 Missing ⚠️
massa-execution-exports/src/types.rs 50.00% 4 Missing ⚠️
massa-api/src/private.rs 0.00% 3 Missing ⚠️
massa-api/src/public.rs 96.87% 2 Missing ⚠️
massa-execution-exports/src/channels.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4646   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work ! Nothing really surprising on the code side. Just need to be sure it works has intended with tests.

@AurelienFT AurelienFT marked this pull request as ready for review February 20, 2024 13:21
@AurelienFT AurelienFT requested a review from sydhds February 22, 2024 12:08
sydhds
sydhds previously approved these changes Feb 22, 2024
@AurelienFT AurelienFT changed the title Feature/draft gather infos aurelien Add gathering of transfers in the node + prep work for ABIs Feb 22, 2024
@AurelienFT AurelienFT enabled auto-merge February 22, 2024 13:03
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trace workflow in execution module seems good to me!

@AurelienFT AurelienFT added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit b75577f Feb 22, 2024
12 checks passed
AurelienFT added a commit that referenced this pull request Feb 27, 2024
* Add 2 RPC endpoint with fake data

* Add stream grpc

* Add initial impl of execution traces for abi calls

* Link job on getting info with API.

* Add draft gather infos

* Cleanup execution trace

* Cargo clippy pass

* Update grpc public & stream api for execution traces

* Execution trace parameters & return value are now ser in json format

* Cargo clippy pass

* Fix execution trace unit tests

* Add serde_json as an optional dep

* Update proto files

* Fix finality filter and add placeholder for slot transfers endpoints

* Format and add a start of logic for compiling results

* Fix compil errors for basic feature

* Fix clippy issues

* Add JSON-RPC structure endpoint

* Flatten code for new abi get_slot_transfers

* Fix tu

* Fix logic in the stream and add it in the gRPC endpoint and Json-RPC

* Format and update massa-runtime

* Revert config change on the client

* Revert changes on initial rolls file

* Fix final broadcast by default on API.

* Fix initial rolls

* Add transfer when calling an SC

---------

Co-authored-by: sydhds <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants