Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gate test framework #4642

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Feature gate test framework #4642

merged 7 commits into from
Feb 14, 2024

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Feb 9, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

The goal of this PR is to avoid building massa_models with test-exports feature when building massa's workspace.

bilboquet
bilboquet previously approved these changes Feb 9, 2024
Copy link
Contributor

@bilboquet bilboquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a34d7a) 71.78% compared to head (dc00150) 71.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4642   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo-Besancon
Copy link
Collaborator Author

@bilboquet @AurelienFT I updated the CI to use rust-script instead of cargo-script that seems unmaintained and caused the unit_tests check to hang.

@Leo-Besancon Leo-Besancon added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 9ce47f7 Feb 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants