Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Link Time Optimization for release_prebuilt profile #4633

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Jan 18, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested review from damip and Leo-Besancon January 18, 2024 15:24
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a34d7a) 71.78% compared to head (52004c3) 71.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4633   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cargo.toml Show resolved Hide resolved
@sydhds sydhds requested a review from bilboquet January 19, 2024 10:47
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea yes! Don't know why the security check failed, let's see if the CI passes with an update from main

@Leo-Besancon
Copy link
Collaborator

I think that this is the problem: https://rustsec.org/advisories/RUSTSEC-2024-0003
@sydhds, can you see if we can resolve this? Or is it like mach where we are waiting on a dependancy to update?

@sydhds sydhds enabled auto-merge January 22, 2024 08:20
@sydhds sydhds added this pull request to the merge queue Jan 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@sydhds sydhds added this pull request to the merge queue Jan 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@Leo-Besancon Leo-Besancon added this pull request to the merge queue Feb 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2024
@Leo-Besancon Leo-Besancon added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit f88b1c6 Feb 14, 2024
12 checks passed
@sydhds sydhds deleted the feature/optim_build_lto branch February 15, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants