Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ci: add checksum + tested with ACT (#4590)" #4595

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Revert "ci: add checksum + tested with ACT (#4590)" #4595

merged 1 commit into from
Dec 15, 2023

Conversation

Leo-Besancon
Copy link
Collaborator

This reverts commit 49257e8.

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@damip damip merged commit 86fa044 into main Dec 15, 2023
10 checks passed
sydhds pushed a commit that referenced this pull request Dec 20, 2023
@Leo-Besancon @sydhds
Revert "ci: add checksum + tested with ACT (#4590)" (#4595)
0be997d 
This reverts commit 49257e8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoudiamoncef aoudiamoncef aoudiamoncef approved these changes

@damip damip Awaiting requested review from damip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leo-Besancon @aoudiamoncef @damip