Test 27 6 wip #4582

Leo-Besancon · 2023-12-08T11:07:59Z

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

codecov · 2023-12-08T11:36:06Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (29f6e6d) 71.76% compared to head (9a4f384) 71.78%.

❗ Current head 9a4f384 differs from pull request most recent head 264f88f. Consider uploading reports for the commit 264f88f to get more accurate results

Files	Patch %	Lines
massa-execution-worker/src/execution.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4582      +/-   ##
==========================================
+ Coverage   71.76%   71.78%   +0.01%     
==========================================
  Files         291      291              
  Lines       51301    51642     +341     
==========================================
+ Hits        36818    37069     +251     
- Misses      14483    14573      +90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

damip · 2023-12-10T11:11:50Z

@Leo-Besancon Let's also do the following to proactively try to fix the regression Dusa observed:

update the toolchain to 1.74.1 on all related projects (massa, massa sc runtime, as ffi bindings) as some bugs were fixed: https://blog.rust-lang.org/2023/12/07/Rust-1.74.1.html
do a cargo update on massa, massa sc runtime and as ffi bindings

This should increase our chances of fixing the unexpected regression

damip · 2023-12-10T11:15:37Z

@Leo-Besancon Since keys are rotated, we should update the securenet faucet

Leo-Besancon · 2023-12-10T11:18:17Z

@Leo-Besancon Since keys are rotated, we should update the securenet faucet

Faucet was updated on wednesday ;). Indead it did not work before as it tried to send coins with an address not in its wallet.

* Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <[email protected]> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <[email protected]> Co-authored-by: sydhds <[email protected]>

Co-authored-by: Leo-Besancon <[email protected]>

Signed-off-by: Jean-François <[email protected]>

* Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <[email protected]> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <[email protected]> Co-authored-by: sydhds <[email protected]> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <[email protected]> * Update massa-sc-runtime Signed-off-by: Jean-François <[email protected]> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <[email protected]> Co-authored-by: Damir Vodenicarevic <[email protected]> Co-authored-by: Moncef AOUDIA <[email protected]> Co-authored-by: Ursulafe <[email protected]> Co-authored-by: Sydhds <[email protected]> Co-authored-by: sydhds <[email protected]> Co-authored-by: Jean-François <[email protected]>

* Add initial chain id impl * Add chain id to jsonrpc, grpc public & grpc private api * Add massa-client features sandbox * Add chain id SC unit test * Fix unit test + add dummy gas costs * Update massa-proto-rs dependency * Update massa-sc-runtime dependency * Add unit test allowing easy update of massa docs * Use chain id through config instead of constants directly * Use chain id everywhere (round 1) (#4594) * Use chain id everywhere (round 1) * Use chain id in massa client --------- Co-authored-by: sydhds <[email protected]> * Remove confusing chain id * Fix some unit tests * Test 27 6 wip (#4582) * Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <[email protected]> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <[email protected]> Co-authored-by: sydhds <[email protected]> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <[email protected]> * Update massa-sc-runtime Signed-off-by: Jean-François <[email protected]> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <[email protected]> Co-authored-by: Damir Vodenicarevic <[email protected]> Co-authored-by: Moncef AOUDIA <[email protected]> Co-authored-by: Ursulafe <[email protected]> Co-authored-by: Sydhds <[email protected]> Co-authored-by: sydhds <[email protected]> Co-authored-by: Jean-François <[email protected]> * Add initial chain id impl * Use chain id everywhere (round 1) (#4594) * Use chain id everywhere (round 1) * Use chain id in massa client --------- Co-authored-by: sydhds <[email protected]> * Fix unit tests (final round) * Minor fix * Revert some nasty insert from bad rebase * Auto gen chain id from VERSION * Cargo clippy && fmt && doc pass * Update massa-sc-runtime dependency --------- Signed-off-by: Jean-François <[email protected]> Co-authored-by: sydhds <[email protected]> Co-authored-by: Leo-Besancon <[email protected]> Co-authored-by: Damir Vodenicarevic <[email protected]> Co-authored-by: Moncef AOUDIA <[email protected]> Co-authored-by: Ursulafe <[email protected]> Co-authored-by: Jean-François <[email protected]>

Leo-Besancon added 5 commits December 8, 2023 12:07

Update addresses and public keys

fa5fb71

Add more info to double staking protection's panic message

934cd40

fmt

779dd3f

update version and genesis

2c63ffa

Update version and CI

1f7347c

Leo-Besancon mentioned this pull request Dec 11, 2023

Update Rust Toolchain and cargo update #4584

Closed

Leo-Besancon and others added 8 commits December 11, 2023 11:22

Update Cargo.lock

5a8ffeb

add community charter

d8bfdf2

Add serde json tests (#4579)

5fd8f43

chore: typo fix (#4589)

cb8e423

* Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <[email protected]> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <[email protected]> Co-authored-by: sydhds <[email protected]>

Merge branch 'main' into test_27_6_wip

a941a7c

ci: add checksum + tested with ACT (#4590)

49257e8

Upgrade-to-latest-toolchain (#4585)

6efec44

Co-authored-by: Leo-Besancon <[email protected]>

Update massa-sc-runtime

9a4f384

Signed-off-by: Jean-François <[email protected]>

Leo-Besancon mentioned this pull request Dec 15, 2023

Bump zerocopy from 0.7.26 to 0.7.31 #4592

Closed

Leo-Besancon and others added 5 commits December 15, 2023 10:13

Cargo update

82bbb67

Remove compatibility layer in tracing (#4535)

0246173

Add deferred_credits initial file for test

b85f8ad

Update Genesis and CI

25f0755

Push back Genesis

0cba8f6

Leo-Besancon marked this pull request as ready for review December 15, 2023 10:20

Leo-Besancon requested a review from damip December 15, 2023 10:20

Same

264f88f

damip merged commit 1425b01 into main Dec 15, 2023
10 checks passed

bilboquet deleted the test_27_6_wip branch May 28, 2024 09:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test 27 6 wip #4582

Test 27 6 wip #4582

Leo-Besancon commented Dec 8, 2023

codecov bot commented Dec 8, 2023 •

edited

Loading

damip commented Dec 10, 2023

damip commented Dec 10, 2023

Leo-Besancon commented Dec 10, 2023

Test 27 6 wip #4582

Test 27 6 wip #4582

Conversation

Leo-Besancon commented Dec 8, 2023

codecov bot commented Dec 8, 2023 • edited Loading

Codecov Report

damip commented Dec 10, 2023

damip commented Dec 10, 2023

Leo-Besancon commented Dec 10, 2023

codecov bot commented Dec 8, 2023 •

edited

Loading