Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization - fr #265

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Localization - fr #265

wants to merge 4 commits into from

Conversation

qdrn
Copy link
Contributor

@qdrn qdrn commented Jan 13, 2024

No description provided.

@qdrn qdrn requested review from gregLibert and Ben-Rey January 13, 2024 21:17
@qdrn qdrn linked an issue Jan 13, 2024 that may be closed by this pull request
@qdrn qdrn force-pushed the 264-localization branch from e1ca1f5 to 91a4359 Compare January 13, 2024 22:47
@Ben-Rey
Copy link
Contributor

Ben-Rey commented Jan 15, 2024

French button leads to 404, do we want to push it ?

@qdrn
Copy link
Contributor Author

qdrn commented Jan 15, 2024

How did you test ?

@qdrn
Copy link
Contributor Author

qdrn commented Jan 15, 2024

I think you can only test one language at a time locally FYI.

@qdrn
Copy link
Contributor Author

qdrn commented Jan 19, 2024

Command to try:

npm run start -- --locale fr

@gregLibert
Copy link
Contributor

Command to try:

npm run start -- --locale fr

This command fails on my end with the following error:

Module not found: Error: Can't resolve '@site/code-snippets/wallet-provider/main/code-snippets/generate-new-account.ts' in '/home/greg/code/docs/docs/build'

This is linked to code snippet generation. I wonder if I need to execute a command before executing the run, but I didn't find anything in the readme file saying so.

@qdrn
Copy link
Contributor Author

qdrn commented Jan 23, 2024

Works for me on a clean install + freshly cloned repo.

➜  ~/dev/docs (264-localization) ✗ npm --version                                          22.36s
10.2.4

@gregLibert
Copy link
Contributor

Works for me on a clean install + freshly cloned repo.

➜  ~/dev/docs (264-localization) ✗ npm --version                                          22.36s
10.2.4

Indeed, a fresh install works thanks.

But once compiled, I don't see any translation. Is it due to the website naming ?

@qdrn
Copy link
Contributor Author

qdrn commented Jan 24, 2024

Nothing is translated. Pages were copied. Now someone can work on it/delete the ones not translated if we don't want to default to english.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization
3 participants