Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to CLI #65

Merged
merged 13 commits into from
Aug 9, 2024
Merged

Add functions to CLI #65

merged 13 commits into from
Aug 9, 2024

Conversation

pivilartisant
Copy link
Collaborator

No description provided.

@pivilartisant pivilartisant marked this pull request as draft August 6, 2024 14:20
@pivilartisant pivilartisant force-pushed the improve-configs branch 2 times, most recently from 15752a9 to 27c8b05 Compare August 6, 2024 14:45
@pivilartisant pivilartisant linked an issue Aug 6, 2024 that may be closed by this pull request
Add fonction to CLI #16
Closed
3 tasks
@pivilartisant pivilartisant changed the title clarify configs improve cli Aug 6, 2024
@pivilartisant pivilartisant force-pushed the improve-configs branch 5 times, most recently from 2ea60dc to ad64c1d Compare August 6, 2024 16:48
@pivilartisant pivilartisant changed the title improve cli Add functions to CLI Aug 6, 2024
@pivilartisant pivilartisant force-pushed the improve-configs branch 3 times, most recently from b4f745f to fde439c Compare August 7, 2024 15:33
@pivilartisant pivilartisant marked this pull request as ready for review August 7, 2024 15:36
@pivilartisant pivilartisant force-pushed the improve-configs branch 3 times, most recently from 207b95a to fcd1b80 Compare August 7, 2024 15:55
thomas-senechal
thomas-senechal requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

Please once every comments are fixed, update the README to make sure it matches the new way to set the wallet nickname and nodeURL.

pkg/website/delete.go Outdated Show resolved Hide resolved
pkg/config/wallet.go Outdated Show resolved Hide resolved
int/cli/config.go Outdated Show resolved Hide resolved
int/cli/config.go Outdated Show resolved Hide resolved
int/cli/config.go Outdated Show resolved Hide resolved
int/api/middlewares.go Outdated Show resolved Hide resolved
pkg/config/network.go Outdated Show resolved Hide resolved
pkg/config/sc.go Outdated Show resolved Hide resolved
@pivilartisant pivilartisant force-pushed the improve-configs branch 2 times, most recently from 3498acc to 38c282a Compare August 8, 2024 11:26
thomas-senechal
thomas-senechal approved these changes Aug 9, 2024
View reviewed changes
pkg/config/wallet.go Outdated Show resolved Hide resolved
@pivilartisant
Revert "add delete fn"
83ba542 
This reverts commit f790544.
@pivilartisant pivilartisant merged commit 31aa7d3 into main Aug 9, 2024
6 checks passed
@thomas-senechal thomas-senechal deleted the improve-configs branch September 5, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-senechal thomas-senechal thomas-senechal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Deploying & Launching Liquity Frontend
Development

Successfully merging this pull request may close these issues.

Add fonction to CLI
2 participants
@pivilartisant @thomas-senechal