Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 error on error pages when a resource is specified #192

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

thomas-senechal
Copy link
Member

When a resource is specified on an error page, for example, http://mmmm.localhost:8080 is supposed to show the "MNS not found" error page (unless someone tool the mmmm domain 🙃). If the url as something after the port, for example http://mmmm.localhost:8080/test , it result in a web browser 404 error which is ugly and bad. We should always show the deweb error page

@thomas-senechal thomas-senechal marked this pull request as ready for review December 16, 2024 23:19
@thomas-senechal thomas-senechal merged commit f5b9269 into main Dec 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants