Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

97 update server with new sc #127

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Conversation

thomas-senechal
Copy link
Member

No description provided.

@thomas-senechal thomas-senechal linked an issue Sep 24, 2024 that may be closed by this pull request
3 tasks
@thomas-senechal thomas-senechal force-pushed the 97-update-server-with-new-sc branch from be152c1 to 1474a2f Compare October 15, 2024 10:40
@thomas-senechal thomas-senechal force-pushed the 97-update-server-with-new-sc branch from 1474a2f to 5c98107 Compare October 16, 2024 09:58
@thomas-senechal thomas-senechal marked this pull request as ready for review October 16, 2024 09:58
@pivilartisant
Copy link
Collaborator

gg

sharing two thoughts:

  • what happens to log size ? is it ever deleted ?
  • thinking ahead, but user might want to delete cache when closing the server app for privacy reason... we might to think about this down the line ?

@thomas-senechal
Copy link
Member Author

  • what happens to log size ? is it ever deleted ?

We use MS logger which handles log size and stuff like that. We could add some settings in the config file, but it's nota priority
https://github.com/massalabs/station/blob/main/pkg/logger/logger.go

  • thinking ahead, but user might want to delete cache when closing the server app for privacy reason... we might to think about this down the line ?

could be a nice privacy feature
We could also think about a RAM cache instead of the disk one, which would be cleaned once the server is shutdown
But not a priority for now

@thomas-senechal thomas-senechal merged commit 0747fdb into main Oct 23, 2024
11 checks passed
@thomas-senechal thomas-senechal deleted the 97-update-server-with-new-sc branch November 21, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update server with new SC
3 participants