This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Only use xdg-open to launch file-manager #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's much preferred to use the default file manager configured by the user.
10 tasks
hualet
suggested changes
Apr 16, 2019
| } else { | ||
| command = QString("xdg-open,%1").arg(filePath); | ||
| } | ||
| command = QString("xdg-open,%1").arg(filePath); |
There was a problem hiding this comment.
The change breaks the old behavior, we can't accept that, maybe you can try DDesktopServices::showFileItem from DTK to see if that satisfy your need?
There was a problem hiding this comment.
Can you explain how this breaks the old behavior?
If I understand correctly, on Deepin (the os) this would still
start dde-file-manager because it's default.
Also, any docs on DDesktopServices::showFileItem?
There was a problem hiding this comment.
The original code
QString("/usr/bin/dde-file-manager,%1?selectUrl=%2).arg(fileDir).arg(filePath)
opens the target directory and select the target file. xdg-open won't do that.
DDesktopServices::showFileItem basically did the same thing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xdg-openis described as the followingIn general
deepin-screenshotshould respect whatever file manager a user has configured as default.So if someone has
dde-file-manageryet they don't want to use it as default, it won't be respected in this application.