Fix ignored headers + unnecessary major version check #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why Outlook emails didn't have any flags. Turns out
data[1]
seems to contain the end ofdata[0][0]
. For the 3 other servers I have tested,data[1]
is just a single closing parenthesis but in the case of Outlook it contains the flags.Here's the an example of the output of
for Gmail:
and here it is for Outlook:
so the fix is to simply concatenate them.
I hope this doesn't break things for other servers, if it does we can just add a check for the length of
data
.Also fixed a version check that's not necessary since Imbox is for 3.3+.