Fixed bugs when dealing with primitives and multiple matching constructors

[JanMosigItemis]

Hi there,

i noticed the following issues the other day and fixed them:

• If a result row column contains primitives, the findConstructor algorithm fails to find a matching constructor if the constructors do use box types or vice versa, e. g. the column contains an int but the constructor of the corresponding POJO takes an Integer.
• If a result row column contains a null reference, an InvocationTargetException having an NPE set as cause might be thrown (depending on the behavior of the POJO's constructor when null arguments are passed). I straightened out the exception handling a bit so that debugging via stack trace gets easier in such situations.

I did also fix a couple of minor issues in the JpaResultMapper unit test cases.

Unfortunately my IDE seems to have a slightly different tab/spaces policy than yours resulting in rather large diffs. If that bothers you, I could try to change the settings and replay my changes.

Regards

[simasch]

Hi Jan,
Thank you very much!

[simasch]

Hi Jan,

Ich denke wir können uns auch auf Deutsch unterhalten ☺

Vielen Dank für Deinen grossen Beitrag.
Es freut mich sehr, dass Du QLRM weiterbringst.

Ich werde noch heute eine neue Version erstellen.

Viele Grüsse aus der Schweiz
Simon Martinelli

Von: Jan Mosig [mailto:[email protected]]
Gesendet: Donnerstag, 18. Februar 2016 15:50
An: simasch/qlrm [email protected]
Betreff: [qlrm] Fixed bugs when dealing with primitives and multiple matching constructors (#12)

Hi there,

i noticed the following issues the other day and fixed them:

· If a result row column contains primitives, the findConstructor algorithm fails to find a matching constructor if the constructors do use box types or vice versa, e. g. the column contains an int but the constructor of the corresponding POJO takes an Integer.

· If a result row column contains a null reference, an InvocationTargetException having an NPE set as cause might be thrown (depending on the behavior of the POJO's constructor when null arguments are passed). I straightened out the exception handling a bit so that debugging via stack trace gets easier in such situations.

I did also fix a couple of minor issues in the JpaResultMapper unit test cases.

Unfortunately my IDE seems to have a slightly different tab/spaces policy than yours resulting in rather large diffs. If that bothers you, I could try to change the settings and replay my changes.

Regards

---

You can view, comment on, or merge this pull request online at:

#12

Commit Summary

• Removed unused imports and member variables -> reduced warning count.
• Fixed bug where target types with multiple constructors with argument
• Improved error handling in case a null is passed to a non null tolerant
• Fixed potential NPE if result row column contains null reference.
• Improved unit tests

File Changes

• M src/main/java/org/qlrm/mapper/JpaResultMapper.javahttps://github.com/Fixed bugs when dealing with primitives and multiple matching constructors #12/files#diff-0 (198)
• M src/main/java/org/qlrm/mapper/ResultMapper.javahttps://github.com/Fixed bugs when dealing with primitives and multiple matching constructors #12/files#diff-1 (30)
• M src/test/java/org/qlrm/generator/ClassGeneratorTest.javahttps://github.com/Fixed bugs when dealing with primitives and multiple matching constructors #12/files#diff-2 (69)
• M src/test/java/org/qlrm/mapper/JdbcResultMapperTest.javahttps://github.com/Fixed bugs when dealing with primitives and multiple matching constructors #12/files#diff-3 (86)
• M src/test/java/org/qlrm/mapper/JpaResultMapperTest.javahttps://github.com/Fixed bugs when dealing with primitives and multiple matching constructors #12/files#diff-4 (268)
• M src/test/java/org/qlrm/to/EmployeeTO.javahttps://github.com/Fixed bugs when dealing with primitives and multiple matching constructors #12/files#diff-5 (59)

Patch Links:

• https://github.com/simasch/qlrm/pull/12.patch
• https://github.com/simasch/qlrm/pull/12.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12.