Find all the files to alter in bash instead of ruby #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the work started here #21, this PR aims at reducing the boot time on big react applications (~1000 files).
For large projects, we can encounter
R10errors because the time spent trying to inject the environment variables on runtime can exceed the default timeout of 60 seconds.This patch is reducing the amount of files pass to the ruby runtime (which is kind of slow), by greping first all the files containing the
REACT_APP_VARS_AS_JSON(in bash). Only the files will be passed to theinjectable_env.rbscript.On my local machine i get the following result with the patch:
time .profile.d/inject_react_app_env.sh .profile.d/inject_react_app_env.sh 1.87s user 0.16s system 82% cpu 2.454 totalAnd without:
time .profile.d/inject_react_app_env.sh .profile.d/inject_react_app_env.sh 13.07s user 6.86s system 90% cpu 22.003 totalwhich can be of a huge help for big apps.