Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite import paths in esm version to use esm version of date-fns. #8

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

trading-peter
Copy link
Contributor

@trading-peter trading-peter commented Jan 25, 2019

This PR adds a step to the build script that rewrites the import paths for date-fns functions to use the esm versions. (fixes #7)

@marnusw marnusw merged commit 79caada into marnusw:master Jan 25, 2019
@marnusw
Copy link
Owner

marnusw commented Jan 25, 2019

Good catch! Thank you for submitting the PR to fix this @pkaske.

I have released 1.0.6-beta.1 since I don't have any easy way to test these changes just now. If you would confirm whether it works fine for you I will do a full release.

@trading-peter
Copy link
Contributor Author

I will do next week and inform you how it went for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esm version imports non esm scripts from date-fns
2 participants